Bug 399314 – Add G_GNUC_WARN_UNUSED_RESULT to gtk_style_attach

2007-01-22  Chris Wilson <chris@chris-wilson.co.uk>

	Bug 399314 – Add G_GNUC_WARN_UNUSED_RESULT to gtk_style_attach

	* gtk/gtkstyle.h:
		Cause gcc to issue a warning if the style returned from
		gtk_style_attach is not used. Failure to update
		widget->style causes some very difficult to identify bugs,
		eg Bug 353498 – crash in Terminal: changing icon theme.

svn path=/trunk/; revision=17199

diff --git a/ChangeLog b/ChangeLog
index 20276fb04a29f7e5e6cfdfdc4a3f541091bafcbb..4f6a87f70aaf72503166b1c9301a8caab2ea5039 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2007-01-22  Chris Wilson <chris@chris-wilson.co.uk>
+
+       Bug 399314 – Add G_GNUC_WARN_UNUSED_RESULT to gtk_style_attach
+
+       * gtk/gtkstyle.h:
+               Cause gcc to issue a warning if the style returned from
+               gtk_style_attach is not used. Failure to update
+               widget->style causes some very difficult to reproduce bugs,
+               eg Bug 353498 – crash in Terminal: changing icon theme.
+
 2007-01-19  Michael Emmel  <mike.emmel@gmail.com>
 
        * gdk/directfb/gdkevents-directfb.c: added fixes for window

diff --git a/gtk/gtkstyle.h b/gtk/gtkstyle.h
index e4f71c6f8da08045d0bafb8d1647398078d804f3..0e758f1eac5b13974d9a06f3976a3682937489e3 100644 (file)
--- a/gtk/gtkstyle.h
+++ b/gtk/gtkstyle.h
@@ -427,7 +427,7 @@ GType     gtk_style_get_type                 (void) G_GNUC_CONST;
 GtkStyle* gtk_style_new                             (void);
 GtkStyle* gtk_style_copy                    (GtkStyle     *style);
 GtkStyle* gtk_style_attach                  (GtkStyle     *style,
-                                             GdkWindow    *window);
+                                             GdkWindow    *window) G_GNUC_WARN_UNUSED_RESULT;
 void     gtk_style_detach                   (GtkStyle     *style);
 
 #ifndef GTK_DISABLE_DEPRECATED